struct MsacAsmContextBuf: Refactor out and unsafe impl Send + Sync#1311
Merged
struct MsacAsmContextBuf: Refactor out and unsafe impl Send + Sync#1311
struct MsacAsmContextBuf: Refactor out and unsafe impl Send + Sync#1311Conversation
rinon
reviewed
Jul 13, 2024
kkysen
force-pushed
the
kkysen/struct-MsacAsmContextBuf-Send-Sync
branch
from
ad679f5 to
0487a2e
Compare
kkysen
force-pushed
the
kkysen/struct-MsacAsmContextBuf-Send-Sync
branch
from
0487a2e to
1ec6eab
Compare
rinon
approved these changes
Jul 15, 2024
kkysen
force-pushed
the
kkysen/struct-MsacAsmContextBuf-Send-Sync
branch
from
1ec6eab to
6856860
Compare
rinon
approved these changes
Jul 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors out
MsacAsmContext::buf_{pos,end}toMsacAsmContextBufand thenunsafe impl Send + Syncon it since it stores pointers from theSend + SyncOption<CArc<[u8]>>inMsacContext::asm. This makesMsacContext: Send + Sync.